FormidableLabs/radium

CSS Grid not supported

Open

#1029 opened on Jun 14, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (7,414 stars) (352 forks)batch import
enhancementhelp wanted

Description

Looks like no browser prefixes get added for CSS Grid (specifically for ie11).

From my initial research it would appear that this is because Support for CSS grid was only introduced by 'inline-style-prefixer' in the latest version (v5.10 -https://github.com/rofrischmann/inline-style-prefixer/blob/master/CHANGELOG.md#510).

Radium currently uses ^v4.0.0. v5 of the style prefixer drops the Create Dynamic prefixer option:

5.0.0
We entirely removed the dynamic version of the prefixer due to constant issues with browser detection and the almost impossible need to keep all the versions updated and in sync. There are no other changes except the import paths for this version.

Improvements, additions and bug fixes will be build on top of the new major version shortly.

Is moving to this version an option? or is keeping the dynamic prefixer more important?

Contributor guide

Tech stack
reactjavascriptcssnodejs
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with ReactUnderstanding of npm dependency management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the current usage of inline style prefixer in the codebase, specifically in package.json and the prefixer module. Then verify the changes in v5.10 as noted in the changelog (https://github.com/rofrischmann/inline style prefixer/blob/master/CHANGELOG.md#510) and consider how to integrate without breaking dynamic prefixer functionality. Consult issue comment for any additional context.