Bug: Infer changeId in a non-caught-up branch PR
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- github-actions, javascript
Research direction
Start by tracing how GitHub Actions supplies build metadata and how formideploy handles changeId, then compare the behavior with the linked workflow run. Done means an unmergeable or out-of-sync PR branch receives an inferred changeId and staging deployment is no longer skipped.
Written by the indexing model from the issue text.
Description
When we have an unmergeable / out-of-sync branch in an open PR, formideploy doesn't infer changeId correctly and skips the staging deploy. See, e.g. https://github.com/FormidableLabs/spectacle/runs/6582133835
[config] Full configuration:
{
"lander": {
"name": "spectacle"
},
"github": {
"org": "FormidableLabs",
"repo": "spectacle"
},
"build": {
"dir": "build",
"path": "build/open-source/spectacle",
"jobId": "2378867420",
"jobUrl": "https://github.com/FormidableLabs/spectacle/actions/runs/2378867420",
"changeId": null,
"isPullRequest": false
},
"site": {
"basePath": "open-source/spectacle",
"redirects": {},
"excludes": []
},
"staging": {
"domain": "formidable-com-spectacle-staging-null.surge.sh"
},
"production": {
"domain": "formidable.com",
"bucket": "formidable.com",
"region": "us-east-1"
}
}
[formideploy] Starting {"action":"staging"} with options
{
"port": 5000,
"limit": 10,
"start": "2022-05-24T21:44:09.045Z",
"dryrun": false,
"production": false,
"staging": true
}
[deploy:staging] Skipping deployment (CI): CI did not provide a build.changeId value (e.g., merge or master build)
Task:
- Infer
changeIdin GH actions for unmergeable PR branches.
- Dominant language
- JavaScript
- Stars
- 7
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FormidableLabs/formideploy
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
-
documentation feature
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 1/5 Under an hour Newbie friendliness 35/100
-
feature
Difficulty 5/5 Over a week Newbie friendliness 20/100
All issues in FormidableLabs/formideploy
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·