Put a space between the commodity symbol and the quantity
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- fsharp
- Domain
- backend
Research direction
Start in Amount.ToString, using AmountStyle.CommoditySpaced and the referenced BalanceReport.fs lines to trace the formatting. Update the expectations in Tabularius.Tests/Data/AmountTests.fs, and use Tabularius.Tests/Interop/BalanceReportTests.fs to confirm the spaced style is preserved. Done means a true value produces one space between the commodity symbol and quantity.
Written by the indexing model from the issue text.
Description
Problem
The AmountStyle type has a CommoditySpaced field. Amount.ToString does not read this field. The method puts the commodity symbol directly before the quantity or directly after the quantity. The method never puts a space between these two parts.
Do these steps:
- Read
AmountStyle.CommoditySpacedinAmount.ToString. - Put one space between the commodity symbol and the quantity if the value of the field is
true. - Correct the tests in
Tabularius.Tests/Data/AmountTests.fs. These tests hold the current behavior.
Why this task is necessary
hledger reports the space in the amount style. The interop layer keeps this data, and Tabularius.Tests/Interop/BalanceReportTests.fs shows the value. The program then removes the space when it shows the amount. The user sees 100USD in place of 100 USD.
Code
- Dominant language
- F#
- Stars
- 1
- Forks
- 0
- Avg merge
- 12h 14m
- Merged PRs (30d)
- 10
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ForNeVeR/tabularius
-
enhancement help wanted
Difficulty 4/5 3-5 days Newbie friendliness 48/100
ForNeVeR/tabularius#80 ·
-
enhancement good first issue help wanted
Difficulty 4/5 3-5 days Newbie friendliness 62/100
ForNeVeR/tabularius#72 ·
-
build status:blocked
Difficulty 3/5 1-2 days Newbie friendliness 48/100
ForNeVeR/tabularius#40 ·
-
Dependency Dashboard Opendashboard
Difficulty 4/5 3-5 days Newbie friendliness 18/100
ForNeVeR/tabularius#3 ·
All issues in ForNeVeR/tabularius
Similar issues
-
bug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100