ForNeVeR/Fenrir

Cancel previous commit requests if selected ref changes

Open

#36 opened on May 13, 2020

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)F# (2 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (34 stars)
PR merge metrics
 (PR metrics pending)

Description

See this TODO comment: https://github.com/ForNeVeR/Fenrir/blob/f091f85b8b09cb1813cfbeb8bcbdf2870e46ad36/Fenrir/Ui/CommitsViewModel.fs#L36-L49

Consider this scenario:

  1. User selects a ref named ref1
  2. This code block starts asynchronous load of commits for ref1
  3. User quickly changes their selection to a ref named ref2
  4. This code block starts another asynchronous load
  5. Load for ref2 my finish earlier than for ref1, so data for ref2 will be loaded into the commit control
  6. And later, when the asynchronous load task for ref1 is finished, it will override the contents of the commit control, which is bad!

Contributor guide

Research direction
Implement cancellation of previous async load when ref selection changes. Use CancellationTokenSource to cancel the previous operation.
Tech stack
None
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitF#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75