FluxML/Flux.jl

Overloading Flux.batch for custom eltypes

Open

#1,821 opened on Jan 3, 2022

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Julia (4,725 stars) (619 forks)batch import
enhancementgood first issuehelp wanted

Description

I ran into a use case for the batch function to operate on generators. I noticed that the batch function is not all that compatible with generators since it doesn't utilize the collect function for them. I'm curious if this additional functionality for the batch function is something that Flux.jl is interested in?

Contributor guide

Tech stack
None
Domain
machine learning
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with JuliaUnderstanding of Flux's batch function
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the current implementation of `Flux.batch` in the Flux.jl repository, likely in files like `src/data/batch.jl`. Understand how it handles different element types and why it does not work with generators. Consider how to overload or extend `batch` to support custom eltypes, possibly by using `collect` on generators. Review the comments in the issue for any suggested approaches or maintainer input.