FluxML/FastAI.jl

`TaskDataset` does not sub-type `MLUtils.AbstractDataContainer`

Open

#252 opened on Jul 25, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Julia (592 stars) (49 forks)batch import
enhancementgood first issuehelp wanted

Description

I would sub-type MLUtils.AbstractDataContainer to get some sensible defaults like Base.iterate defined on top of the MLUtils.jl interface.

Contributor guide

Tech stack
None
Domain
machine learningdata
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Julia programmingMLUtils.jl basicsFastAI.jl TaskDataset
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
First, study the MLUtils.AbstractDataContainer interface as defined in the linked MLUtils.jl file (https://github.com/JuliaML/MLUtils.jl/blob/387b371287d00ce7e40a1be092db0dc4ad624b58/src/observation.jl#L75). Then, examine the current TaskDataset struct in FastAI.jl to understand its fields and methods. Check the 3 comments on the issue for any additional context or suggestions. Implement the sub typing and ensure that the default methods from MLUtils are properly inherited or overridden if needed.