Flow-Launcher/Flow.Launcher

BUG: Calculator can't multiply numbers with more than 19 digits

Open

#2673 opened on Apr 25, 2024

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C# (14,678 stars) (598 forks)batch import
bughelp wantedkeep-fresh

Description

Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

Problem Description

Calculator is providing wrong result if one of the two numbers being multiplied is more than 19 digits. Examples:

  1. 1.2*0.83333333333333333333
  2. 2453*23534245034253633353
  3. 1*0.22222222222222222222
  4. 1*24353532424240053022
  5. 1*1111111111111111111111
  6. 1324*30000000000000000000

It's easiest to see this issue in action if you copy and paste the above examples and then remove just the last digit. We will notice a large change in the result.

But there are some instances where this doesn't happen. I am unable to determine the logic behind when this issue occurs and when it does not. Examples:

  1. 1*0.11111111111111111111
  2. 1324*10000000000000000000
  3. 1324*40000000000000000000

To Reproduce

No response

Screenshots

No response

Flow Launcher Version

1.18.0

Windows Build Number

10.0.22631.3447

Error Log

No response

Contributor guide

Tech stack
csharp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#basic understanding of numeric types
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the calculator plugin's multiplication implementation, likely in C# code. Check for usage of double vs decimal or BigInteger. Identify where precision loss occurs. Refer to issue examples and any comments for additional context. Propose switching to decimal or BigInteger if needed.