BUG: Flow Launcher not gracefully shutting down when invoking taskkill · Flow-Launcher/Flow.Launcher#2604

(2 comments) (0 reactions) (0 assignees)C# (14,678 stars) (598 forks)batch import

bughelp wantedkeep-fresh

Description

Checks

I have checked that this issue has not already been reported.
I am using the latest version of Flow Launcher.

Problem Description

During developement of my plugin, I noticed that flow launcher is not shutting down gracefully when using "taskkill /IM Flow.Launcher.exe" to stop the app. Causing me to use the /F (Force) flag. I don't think this is intended so reporting this here. This is especially useful to deploy .NET plugin builds automatically by creating a run config that does:

Kill FlowLauncher
Deploy new .dll to plugin folder
Start FlowLauncher again

Interesting is that when I Invoke the taskkill command, the shortcut to open FlowLauncher doesn't work anymore.

To Reproduce

Start FlowLauncher
Invoke "taskkill /IM Flow.Launcher.exe"
Program is still running, but shortcut for search doesn't work anymore

PowerShell Commands:

Start-Process C:\Users\[user]\AppData\Local\FlowLauncher\Flow.Launcher.exe
taskkill /im Flow.Launcher.exe
tasklist /FI "IMAGENAME eq Flow*"

See Screenshot. I waited few seconds between the commands of course.

Screenshots

Flow Launcher Version

1.17.2

Windows Build Number

10.0.22631.3155

Error Log

I did a fresh log clear before copying the log. But it does not seem to log the taskkill event in the log.


15:59:17.1556+01:00 - INFO  - App.OnStartup - Begin Flow Launcher startup ----------------------------------------------------
15:59:17.1556+01:00 - INFO  - App.OnStartup - Runtime info:
Flow Launcher version: 1.17.2
OS Version: 22631.3155
IntPtr Length: 8
x64: True
15:59:17.3208+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Process Killer> is <1ms>
15:59:17.3208+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <ModdedMinecraft> is <1ms>
15:59:17.3208+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Plugin Indicator> is <1ms>
15:59:17.3208+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <System Commands> is <1ms>
15:59:17.3304+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <URL> is <19ms>
15:59:17.3304+01:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://fastly.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
15:59:17.3304+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Web Searches> is <20ms>
15:59:17.3304+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Shell> is <21ms>
15:59:17.3439+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Calculator> is <26ms>
15:59:17.3439+01:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Preload programs cost <6ms>
15:59:17.3439+01:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Number of preload win32 programs <225>
15:59:17.3439+01:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Number of preload uwps <46>
15:59:17.3439+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Windows Settings> is <29ms>
15:59:17.3439+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Browser Bookmarks> is <32ms>
15:59:17.3611+01:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://gcore.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
15:59:17.3611+01:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://cdn.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
15:59:17.3611+01:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://raw.githubusercontent.com/Flow-Launcher/Flow.Launcher.PluginsManifest/plugin_api_v2/plugins.json
15:59:17.3611+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Program> is <48ms>
15:59:17.3611+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Explorer> is <49ms>
15:59:17.3778+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Steam Search> is <58ms>
15:59:17.4659+01:00 - INFO  - CommunityPluginSource.FetchAsync - Loaded 151 plugins from https://cdn.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
15:59:17.4680+01:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Plugins Manager> is <150ms>
15:59:17.6187+01:00 - INFO  - App.OnStartup - Dependencies Info:
Python Path: 
Node Path: 
15:59:17.8267+01:00 - INFO  - App.OnStartup - End Flow Launcher startup ----------------------------------------------------  
15:59:17.8267+01:00 - INFO  - App.OnStartup - Startup cost <728ms>
15:59:18.4111+01:00 - INFO  - ImageLoader.Initialize - Preload images cost <1059ms>
15:59:18.4111+01:00 - INFO  - ImageLoader.Initialize - Number of preload images is <91>, Images Number: 91, Unique Items 58

Contributor guide

Tech stack: csharp
Domain: desktop
Issue type: bug
Difficulty: 3
Estimated time: 1-3 hours
Activity status: fresh
Clarity: clear
Prerequisites: C#Windows API basics
Newbie friendliness: 45
Research direction: Investigate how Flow Launcher handles the `WM CLOSE` message sent by `taskkill` without `/F`. Look at the application's main window closing event in `App.xaml.cs` or `MainWindow.xaml.cs`. Check if the `OnStartup` or `OnExit` methods properly handle shutdown signals. Also verify if the application registers a console control handler. The issue reports that the process continues running and the shortcut stops working, suggesting the window event is not correctly processed. Review the source code at `Flow.Launcher/` for shutdown logic.