Flipboard/bottomsheet

BottomSheetLayout does not update height when content layout is changed

Open

#117 opened on Jan 29, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (4,540 stars) (609 forks)batch import
enhancementhelp wanted

Description

I have a layout with a content view and a progress view. While an info is loading the progress bar is showing. The problem appears when I show the content view. BottomSheetLayout does not change height to show the new content.

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android development basicsView measurement understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the onMeasure and onLayout methods in BottomSheetLayout.java to understand how the height is calculated. Consider adding a ViewTreeObserver.OnGlobalLayoutListener to detect content size changes and trigger a re layout. Check the issue comments for any suggested solutions or reproduction steps.