Typos in theme pak192comic.tab and pak192comicxxl.tab

Open Beginner friendly
#94 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Domain
content

Research direction

Inspect pak192comic.tab at lines 15 and 97, then compare the corresponding entries at lines 26 and 107 in pak192comicxxl.tab. Correct the suspected parameter-name and assignment typos, then verify that loading the pak192.comic theme in Extended no longer produces the reported errors and warnings.

Written by the indexing model from the issue text.

Description

clearity good first issue

While using the pak192.comic theme in Extended, I noticed the following error and warning messages:

ERROR: tabfile_t::find_parameter_expansion: Found invalid character '-' in key of parameter expansion (Only alphanumeric characters, '.' and '_' allowed) For help with this error or to file a bug report please see the Simutrans forum: https://forum.simutrans.com
Warning: tabfile_t::read: No data in " "

Based on this forum post, I suspect that the font-size in line 15 should be font_size (and also in pak192comicxxl.tab line 26).

ERROR: tabfile_t::find_parameter_expansion: Found invalid character ' ' in key of parameter expansion (Only alphanumeric characters, '.' and '_' allowed) For help with this error or to file a bug report please see the Simutrans forum: https://forum.simutrans.com

Possibly an artifact of the previous warning?

Warning: tabfile_t::read: No data in "gui_color_ticker_divider #cfb094"

I think it's just a missing = in line 97 (pak192comicxxl.tab line 107)?

(This post will inevitably contain a typo too, in line with Muphry's Law!)

Dominant language
Shell
Stars
27
Forks
19
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Flemmbrav/Pak192.Comic

All issues in Flemmbrav/Pak192.Comic

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.