Flagsmith/flagsmith

Web Hook sends only one type of event (FLAG_UPDATED)

Open

#72 opened on Jan 9, 2021

View on GitHub
 (7 comments) (0 reactions) (3 assignees)Python (3,475 stars) (264 forks)batch import
featuregood first issuetech-debt

Description

Hi,

It is quite stupid to have one type for many events. Suggestion: On feature_segment update sends : FLAG_SEGMENT_UPDATED On feature_identity update sends : FLAG_IDENTITY_UPDATED on feature update sends : FLAG_FEATURE_UPDATED

Contributor guide

Tech stack
python
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of webhooksFamiliarity with PythonKnowledge of event driven patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the webhook sending logic in the backend codebase to locate where FLAG UPDATED events are dispatched. Identify the relevant files and functions handling event types. Review the comments on the issue for any additional context or suggested implementation details. Consider adding new event types like FLAG SEGMENT UPDATED, FLAG IDENTITY UPDATED, and FLAG FEATURE UPDATED, ensuring they are triggered at appropriate points.
Web Hook sends only one type of event (FLAG_UPDATED) · Flagsmith/flagsmith#72 | Good First Issue