Flagsmith/flagsmith

Show a warning when closing the drawer after creating a not saved feature-specific segment

Closed

#5,368 opened on Apr 22, 2025

View on GitHubContributor guide
 (7 comments) (0 reactions) (0 assignees)Python (264 forks)batch import
front-endgood first issueimprovement

Repository metrics

Stars
 (3,475 stars)
PR merge metrics
 (Avg merge 3d 7h) (157 merged PRs in 30d)

Description

Is your feature request related to a problem?

At the moment, we create a feature-specific segment within the feature modal but the user needs to manually attach it. This feature aims to add a warning to confirm the user wants to close the modal without linking it to the feature.

Describe the solution you'd like.

Open a modal to confirm the user does not want to add it now

Describe alternatives you've considered

Automatically add the segment to the feature

Additional context

No response

Contributor guide

Research direction
Look for the frontend drawer component used during feature creation, likely in the 'frontend/' directory. Search for existing confirmation dialogs as a pattern. The issue comments may contain additional context about the expected behavior. Ensure to handle the closing event of the drawer to show a warning modal only when a segment has been created but not attached.
Tech stack
None
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React basicsknowledge of modal patternsawareness of segment creation flow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75