Using django-lifecycle hooks results in `error: Untyped decorator makes function "x" untyped [misc]` · Flagsmith/flagsmith#5240

(4 comments) (0 reactions) (1 assignee)Python (3,475 stars) (264 forks)batch import

good first issue

Description

When using the @hook decorator from django-lifecycle on a model method, mypy throws the following error:

error: Untyped decorator makes function "x" untyped [misc]

This means that, currently, all methods decorated with @hook(...) are annotated with # type: ignore[misc]. The goal of this issue is to remove those type: ignore[misc] comments, while still having mypy pass its validation. Depending on the fix, it may be necessary to split the work up into multiple PRs as there are a lot of instances of this across the codebase.

Here is an example: https://github.com/Flagsmith/flagsmith/blob/main/api/features/models.py#L142

Contributor guide

Tech stack: python
Domain: backend
Issue type: bug
Difficulty: 3
Estimated time: 1-2 days
Activity status: blocked
Clarity: clear
Prerequisites: PythonmypyDjangodecorators
Newbie friendliness: 45
Research direction: Examine the linked file and other occurrences of @hook decorator across the codebase. Investigate how django lifecycle defines the decorator and consider if a mypy plugin or type stubs can be added. Also check for any existing discussions in the comments on potential fixes.