Flagsmith/flagsmith

Permalinks to features do not work if the feature is after the first page

Open

#4,239 opened on Jun 25, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (3,475 stars) (264 forks)batch import
buggood first issue

Description

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

This link points to a feature in a project with more than 50 features, which causes pagination: https://app.flagsmith.com/project/18444/environment/UgLNVEFpLooRAwiwLdY8bR/features?feature=97961&tab=value

Because the target feature is located on the second page, the feature modal does not open and the link just lands you on the first page of features.

Steps To Reproduce

  1. Create over 50 features in a project
  2. Try to open a link to any feature after the first page

Expected behavior

Permalinks to features should work no matter how many features a project has.

Screenshots

No response

Contributor guide

Tech stack
pythonreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of paginationexperience with React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The bug occurs because the permalink does not handle cases where the target feature is on a different page. Investigate the frontend code that reads the 'feature' query parameter and opens the modal. Look at how pagination is implemented, likely in the features list component. Ensure that when a feature ID is provided, the correct page is loaded before opening the modal.
Permalinks to features do not work if the feature is after the first page · Flagsmith/flagsmith#4239 | Good First Issue