Fix Go doc-comment association for maxPages and getList

Open
#49 0 comments 0 reactions 1 assignee View on GitHub

@khvn26 is already working on this.

Since Jul 28, 2026.

Assessment

This issue has not been assessed yet.

Description

Summary

Move the maxPages constant and its documentation above the getList doc comment in internal/api/client.go.

Rationale

The current declaration is positioned between the getList documentation and the function. As a result, Go documentation associates the trailing paragraph with maxPages, while getList no longer has a correctly attached doc comment.

Affected area

  • internal/api/client.go
    • maxPages
    • (*Client).getList

Required change

Reorder the declarations so that:

  1. maxPages is immediately preceded by its own // maxPages ... comment.
  2. The // getList ... comment immediately precedes func (c *Client) getList(...).

Acceptance criteria

  • maxPages and getList each have a correctly attached Go doc comment.
  • The change is documentation/declaration ordering only; pagination behaviour remains unchanged.

Backlinks

Dominant language
Go
Stars
12
Forks
3
Avg merge
14h 56m
Merged PRs (30d)
8

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Flagsmith/flagsmith-cli

All issues in Flagsmith/flagsmith-cli

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.