FedML-AI/FedML

Why aggregation algorithm has different name but identical implementation

Open

#1,140 opened on Jun 28, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (743 forks)batch import
help wantedquestion

Repository metrics

Stars
 (3,930 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I have been testing other aggregation algorithms implemented in python/fedml/ml/aggregator/agg_oeprator.py. I realize all aggregation methods represent identical implementation. It means no matter which algorithm you select, in the end, the result will be the same. However, there are a few methods like SCAFFOLD and MIME have different way implementations but they are also giving errors as they require a totally different weight structure.

Is anyone explain to me why all algorithms have identical implementation codes and why SCAFFOLD expects a different weight structure?

This is the location I am talking about:

https://github.com/FedML-AI/FedML/blob/64715d4fb56a90e4106872f503815d978d32f8e6/python/fedml/ml/aggregator/agg_operator.py#L35C1-L35C45

Thanks for your kind support.

Contributor guide

Research direction
Compare the implementations in agg operator.py, focusing on the placeholders or default functions that lead to identical behavior. For SCAFFOLD and MIME, trace the weight structures expected and note where errors occur.
Tech stack
python
Domain
backend
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80