Farama-Foundation/Gymnasium

[Proposal] Allow to specify dtype for Discrete

Open

#1118 opened on Jul 13, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (4,712 stars) (567 forks)batch import
enhancementgood first issue

Description

Proposal

Add dtype argument to spaces.Discrete (similar to MultiDiscrete and Box).

Motivation

Currently the dtype is fixed to numpy.int64. However, often Discrete spaces are much smaller, resulting in a waste of memory.

Pitch

No response

Alternatives

No response

Additional context

No response

Checklist

  • I have checked that there is no similar issue in the repo

Contributor guide

Tech stack
pythonnumpy
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic numpy knowledgeUnderstanding of Gymnasium Discrete space
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The Discrete space implementation is located in gymnasium/spaces/discrete.py. Similar dtype parameters exist in MultiDiscrete and Box spaces, which can serve as reference. The issue has 3 comments suggesting potential implementation details. No linked PRs. The task involves adding a dtype parameter to the init method and ensuring it is used in sampling and other methods.