Famous/engine

[bug?] Moving a Node to another parent Node causes DOMElement refresh (visible blink).

Open

#472 opened on Aug 17, 2015

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (262 forks)batch import
help wanted

Repository metrics

Stars
 (1,750 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When we move a child Node to another parent Node, the child Node's DOMElement's HTMLElement will be destroyed and a new one will be generated.

This forces us to reappend elements of other frameworks (f.e. a React component container) to the new HTMLElement of the DOMElement once it's ready.

The process of re-attaching a React component's HTMLElement container causes a visual blink as in this video: <placeholder for video>

The blink is janky. It'd be nice if a DOMElement's HTMLElement was re-used.

cc @alexanderGugel @michaelobriena

Contributor guide

Research direction
Investigate the 'move' operation for Node to parent Node and trace whether the DOMElement's HTMLElement is being reused or destroyed and recreated.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70