Famous/engine

[bug?] Moving a Node to another parent Node causes DOMElement refresh (visible blink).

Open

#472 opened on Aug 17, 2015

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (1,750 stars) (262 forks)batch import
help wanted

Description

When we move a child Node to another parent Node, the child Node's DOMElement's HTMLElement will be destroyed and a new one will be generated.

This forces us to reappend elements of other frameworks (f.e. a React component container) to the new HTMLElement of the DOMElement once it's ready.

The process of re-attaching a React component's HTMLElement container causes a visual blink as in this video: <placeholder for video>

The blink is janky. It'd be nice if a DOMElement's HTMLElement was re-used.

cc @alexanderGugel @michaelobriena

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
JavaScriptDOM basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate how the engine handles node reparenting, likely in the DOMElement module. Check if there's a method to reuse HTMLElements when a node is moved. Look at the source code for node movement logic and any existing tests. Review the comments on the issue for any additional context or attempted fixes.