Famous/engine

removeScene does not remove the selector from Compositor

Open

#377 opened on Jul 2, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,750 stars) (262 forks)batch import
help wanted

Description

in FamousEngine.removeScene, there is no reference to the Compositor. For embedded uses (like in an existing Angular app), the selector may come and go as the user navigates the app. Therefore it is important to be able to destroy and recreate the Scene as necessary.

Currently, the Compositor will never create a new Context for a selector that's already been used. When the Scene is removed from the FamousEngine, it also needs to remove the selector from the Compositor. When a Scene / selector is removed from the Compositor, the Compositor should take care of cleaning-up and releasing any existing resources (ie. ElementCache).

This will probably require an additional command type in Commands which is handled by the Compositor directly.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Famous Engine's Compositor and CommandsFamiliarity with the codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the Compositor class to understand how selectors are stored and associated with contexts. Look at the Commands system to see how new command types are added and handled. Find where ElementCache resources are released. Then implement a new command (e.g., 'REMOVE SELECTOR') that the Compositor processes to clean up the selector and release associated resources. Ensure that when removeScene is called, this command is dispatched. Reference the existing code in src/engine/Compositor.js and src/engine/Commands.js.