Famous/engine

GestureHandler doesn't fire "tap" for IE<11

Open

#323 opened on Jun 22, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,750 stars) (262 forks)batch import
bughelp wanted

Description

GestureHandler doesn't work for IE 10 and below. In famous-carousel, I've worked around it by calling this directly on the DOM element when IE is detected:

arrowEl.attachEvent("onclick", emitPageChange);

MS docs say addEventListener should work for IE 9+, but this doesn't seem to be the case. I could only get it to recognize clicks by calling attachEvent.

I loathe IE as much as anyone, but there are still a lot of systems running IE 9 & 10 and Famo.us does run on them for the most part. I looked through the engine code and from what I can tell, DOMElement.prototype.on() might be the place to modify. Would something like this be better placed under polyfills, if the Famo.us team finds it acceptable?

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with JavaScript DOM eventsUnderstanding of browser compatibilityKnowledge of polyfills
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the DOMElement.prototype.on method in Famous Engine's codebase. The user suggests adding an attachEvent fallback for IE<11. Review existing polyfills in the project to determine if a similar approach is used elsewhere. The issue mentions that addEventListener doesn't work for IE9/10, so testing with those browsers is necessary. Check comments on the issue for any additional insights or prior attempts.