Fallout-build/Fallout

Rename legacy s_-prefixed private fields to camelCase and enforce the rule

Closed

#481 opened on Jul 12, 2026

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)C# (13 forks)github user discovery
enhancementgood first issuetarget/backlog

Repository metrics

Stars
 (111 stars)
PR merge metrics
 (Avg merge 2d 15h) (63 merged PRs in 30d)

Description

Problem

.editorconfig:73-85 mandates camelCase private fields (no _/m_/g_/s_ prefix, per CSharpGuidelines AV1702/AV1705) but keeps severity = suggestion because ~35 legacy s_-prefixed identifiers across ~34 files still violate it (e.g. Telemetry.s_confirmedVersion). The convention is documented but not compiler-enforced, so new violations slip in. Surfaced in #451 review.

Outcome

No prefixed private fields remain; the naming rule is warning, so new violations fail the build.

Acceptance criteria

  • All s_/_/m_/g_-prefixed private fields in src/**/*.cs renamed to camelCase
  • dotnet_naming_rule.private_fields_should_be_camel_case.severity bumped suggestion → warning (.editorconfig:78)
  • Build green with no new naming warnings

Notes

Mechanical rename; exclude generated code. Low priority.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.