FEniCS/dolfinx

PETSc error code checking

Open

#4,045 opened on Jan 23, 2026

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C++ (255 forks)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (1,158 stars)
PR merge metrics
 (PR metrics pending)

Description

We do not perform consistent error code checking of the PETSc error codes returned by function invocations. Not dealing with the returned error code will become a compiler warning in the future, ref https://gitlab.com/petsc/petsc/-/blob/main/include/petscsystypes.h#L54-57.

Verifiable by configuring PETSc with --with-strict-petscerrorcode ([[no-discard]] marking of PetscErrorCode) and building with -Werror.

Contributor guide

Research direction
Examine source files for calls to PETSc functions that return PetscErrorCode and ensure the return value is checked. Use the with strict petscerrorcode configure flag to enable warnings.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++PETSc
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20