Handling of COMMAND-parameters: info-text not shown
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- lua
- Domain
- embedded-iot
Research direction
Start by locating the Lua handling for command-parameter responses and compare it with the COMMAND sequence diagram in the linked CRSF specification. Reproduce a device response with ready status (0x00) and an info-text such as "OK" or "Failed"; done means that text is displayed as it is in the TBS Agent.
Written by the indexing model from the issue text.
Description
If the LUA starts a command-parameter, it writes (0x2d) the parameter with status (0x01).
If the device immediate executes the command if may - according to the TBS specs - answer with status (ready: 0x00) and send an additional info-text (like "OK" or "Failed").
But this info-text isn't displayed.
Refer to the sequence diagram: https://github.com/tbs-fpv/tbs-crsf-spec/blob/main/crsf.md#command
The last arrow shows the info text in the frame (status: ready, Info: "OK").
I think this is missing in the LUA
The TBS Agent seems to work correctly in this regard.
- Dominant language
- Lua
- Stars
- 13
- Forks
- 6
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 10
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ExpressLRS/Lua
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
ExpressLRS/Lua#32 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
ExpressLRS/Lua#16 · 4 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
ExpressLRS/Lua#11 ·
Similar issues
-
Nmap
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LandSandBoat/server#11579 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100