Example builds using old version of Excel DNA

Open
#7 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp

Research direction

Start with Logging/Logging.csproj around line 74 and reproduce the example after restoring ExcelDna.AddIn 0.34.6 with Update-Package -reinstall. Compare the generated build events and package targets with the referenced revision; done means the sample builds with the current package and logs do not all go to the Diagnostic Display.

Written by the indexing model from the issue text.

Description

Your Logging example works fine for me out of the box, but when I use NuGet to get the latest version of Excel DNA (0.34.6) and use the command 'Update-Package -reinstall', all logs go through the Diagnostic Display regardless of what I do.

image

The build event code ends up being replaced with:
<PostBuildEvent> </PostBuildEvent> </PropertyGroup> <Import Project="packages\ExcelDna.AddIn.0.34.6\tools\ExcelDna.AddIn.targets" Condition="Exists('packages\ExcelDna.AddIn.0.34.6\tools\ExcelDna.AddIn.targets')" /> <Target Name="EnsureExcelDnaTargetsImported" BeforeTargets="BeforeBuild" Condition="'$(ExcelDnaTargetsImported)' == ''"> <Error Condition="!Exists('packages\ExcelDna.AddIn.0.34.6\tools\ExcelDna.AddIn.targets') And ('$(RunExcelDnaBuild)' != '' And $(RunExcelDnaBuild))" Text="You are trying to build with ExcelDna, but the NuGet targets file that ExcelDna depends on is not available on this computer. This is probably because the ExcelDna package has not been committed to source control, or NuGet Package Restore is not enabled. Please enable NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=317567." HelpKeyword="BCLBUILD2001" /> <Error Condition="Exists('packages\ExcelDna.AddIn.0.34.6\tools\ExcelDna.AddIn.targets') And ('$(RunExcelDnaBuild)' != '' And $(RunExcelDnaBuild))" Text="ExcelDna cannot be run because NuGet packages were restored prior to the build running, and the targets file was unavailable when the build started. Please build the project again to include these packages in the build. You may also need to make sure that your build server does not delete packages prior to each build. For more information, see http://go.microsoft.com/fwlink/?LinkID=317568." HelpKeyword="BCLBUILD2002" /> </Target> <PropertyGroup> <PreBuildEvent> </PreBuildEvent>

See: https://github.com/Excel-DNA/Samples/blob/f5a9e7a07fd260aad57d4fc86c69acdb952c8ed3/Logging/Logging.csproj#L74

Dominant language
C#
Stars
135
Forks
83
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Excel-DNA/Samples

All issues in Excel-DNA/Samples

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.