EverestAPI/Everest

FMOD live update crash when restarting after Everest update

Open

#810 opened on Aug 29, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (104 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (503 stars)
PR merge metrics
 (PR metrics pending)

Description

When restarting the game after an in-game Everest update with FMOD Live Update enabled, FMOD crashes with ERR_NOTREADY. Sample crash log:

Ver 1.4.0.0-fna [Everest: 4886-azure-e5327]
07/10/2024 23:52:11
System.Exception: FMOD Failed: ERR_NOTREADY (Operation could not be performed because specified sound/DSP connection is not ready.)
   at Celeste.Audio.CheckFmod(RESULT result) in /home/vsts/work/1/s/Celeste.Mod.mm/Patches/Audio.cs:line 42
   at Celeste.AudioExt.CheckFMOD(RESULT result) in /home/vsts/work/1/s/Celeste.Mod.mm/Patches/Audio.cs:line 392
   at Celeste.Audio.Banks.Load(String name, Boolean loadStrings) in /home/vsts/work/1/s/Celeste.Mod.mm/Patches/Audio.cs:line 337
   at DMD<System.Void Celeste.Audio:Init()>()
   at Celeste.Mod.SpeedrunTool.Other.MuteInBackground.AudioOnInit(orig_Init orig)
   at Hook<System.Void Celeste.Mod.SpeedrunTool.Other.MuteInBackground::AudioOnInit(On.Celeste.Audio+orig_Init)>()
   at SyncProxy<System.Void Celeste.Audio:Init()>()
   at DMD<System.Void Celeste.GameLoader:LoadThread()>(GameLoader this)
   at SkinModHelper.Module.SkinModHelperModule.GameLoaderLoadThreadHook(orig_LoadThread orig, GameLoader self)
   at Hook<System.Void SkinModHelper.Module.SkinModHelperModule::GameLoaderLoadThreadHook(On.Celeste.GameLoader+orig_LoadThread,Celeste.GameLoader)>(GameLoader )
   at Hook<System.Void Celeste.Mod.SkinModHelper.LoaderHook::GameLoaderLoadThreadHook(On.Celeste.GameLoader+orig_LoadThread,Celeste.GameLoader)>(GameLoader )
   at SyncProxy<System.Void Celeste.GameLoader:LoadThread()>(GameLoader )
   at Celeste.RunThread.RunThreadWithLogging(Action method)

Contributor guide

Research direction
Investigate the FMOD initialization sequence during restart after an Everest update. The crash occurs because FMOD Live Update is not ready when Audio.Banks.Load is called. Check if there is a race condition or if the FMOD system needs to be re initialized properly after the update.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#FMOD
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40