Eugeny/tabby

Add an option to disable automatic text selection when right clicking on macOS

Open

#9,237 opened on Nov 15, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (71,314 stars) (4,018 forks)batch import
Good first issueOS: macOST: Enhancement

Description

Version: 1.0.204 Platform: macOS x64 14.1.1 Plugins: none Frontend: xterm-webgl

I'm running tabby 1.0.204 on MacBook Pro (MacOS 14.1.1) and the 'Right click' in 'Mouse' settings is set to 'Paste'. When I mark a text string and right-click mouse button without moving mouse pointer, the text will be pasted at the cursor position as expected. If I moved the mouse pointer to another text string, then right-click will actually copy the text where mouse pointer points to and paste it at the cursor position instead of the text marked previously.

This behavior doesn't happen on Windows 10/11 (same Tabby version) and I think it is not correct since 'Right click' of 'Mouse' is set to 'Paste', not anything else. By the way, this also happens in previous Tabby versions for MacOS.

Thanks.

tabby 00 tabby 01 tabby 02

Contributor guide

Tech stack
typescriptelectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ElectronmacOS event handlingxterm.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the right click behavior in Tabby on macOS by examining the xterm.js mouse event handling in xterm addon webgl. The issue likely stems from macOS specific right click behavior that triggers text selection. Check the event propagation in the Electron webview or xterm's 'selection' event. Consider adding an option to disable automatic text selection on right click.