Eugeny/tabby

Flash frame/taskbar icon on terminal bell

Open

#8981 opened on Sep 14, 2023

View on GitHub
 (2 comments) (2 reactions) (0 assignees)TypeScript (71,314 stars) (4,018 forks)batch import
Good first issueT: Enhancementhelp wanted

Description

Is your feature request related to a problem? Please describe. I am missing this feature which other terminals (Windows Terminal, putty) have - when bell comes and the terminal application does not have keyboard focus (it is minimized or another application is selected), it flashes the taskbar icon (on Windows).

Describe the solution you'd like When bell comes, Tabby should check config whether to flash frame and call relevant function. In Electron this can be achieved by this api. It seems it's working on macOS as well (bouncing icon), don't know about Linux.

In addition, it would be good to change the Tabby settings to allow the user to choose more responses to the bell. See attached screenshot from Windows Terminal bellow.

Describe alternatives you've considered There is no alternative but to not use Tabby 😄

Additional context image Windows Terminal bell settings - Flash window is Visual in Tabby, Flash taskbar is this feature request

Contributor guide

Tech stack
typescriptnodejselectron
Domain
frontenddesktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with TypeScriptbasic Electron API knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate how the terminal bell is currently handled in Tabby (search for 'bell' in the codebase). Implement flash frame using Electron's BrowserWindow.flashFrame() method as described in the issue. Also consider adding a setting for bell behavior similar to Windows Terminal. Look at existing settings structure to extend it.