Eugeny/tabby

Missing option to automatically close tab when connection is lost

Open

#8,062 opened on Mar 10, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (71,314 stars) (4,018 forks)batch import
Good first issuePlugin: SSHT: Enhancement

Description

Discussed in https://github.com/Eugeny/tabby/discussions/8061

Originally posted by jarnek73 March 10, 2023 Hi!

I use tabby to mostly connect to my Ubuntu servers for remote administration. I miss the option to have tabby automatically close the tab when a connection is lost, eg. when doing a reboot. So when a ssh-connection is lost, i can choose to let it ask if i want to reconnect like it does now (default), or i can choose to let it close the tab instead (optional). Hope it makes sense and you will consider this option for a future release.

Contributor guide

Tech stack
typescript
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptElectron basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests an option to automatically close a tab when the SSH connection is lost. Likely, the implementation involves handling a 'disconnect' event in the SSH connection class and adding a configuration toggle in the settings UI. Look for existing event listeners in the terminal component files, possibly under 'app/src/'. Since the issue has no comments, the contributor should first ask for clarification on the expected behavior and whether the setting should be per tab or global.