OperatorCut is returning two empty geometries if there are no valid cuts. A geometry cursor containing only a null pointer should be returned instead.
@stolstov is already working on this.
Since Jul 9, 2014.
Assessment
This issue has not been assessed yet.
Description
The cases in question are
- the cuttee and the cutter don't intersect at all
- the cuttee is a polygon and cutter doesn't pass all the way through it
- the cuttee is a polyline, the cutter touches the cuttee but b_consider_touch is false.
Currently, a pointer to a geometry cursor is returned. There are two empty geometries in the cursor, one for the left cut and one for the right cut. It would be a more obvious signal to the user that there were no valid cuts if a null pointer was returned instead.
Here are some simple cases to reproduce the issues listed above.
cutter1: {"paths":[[[1.5,0.5],[2.5,0.5]]]}
cutter2: {"paths":[[[0.5,0.5],[1.5,0.5]]]}
cutter3: {"paths":[[[0.2,0.4],[0.6,0.8]]]}
polygon (cuttee): {"rings":[[[0,0],[0,1],[1,1],[1,0],[0,0]]]}
polyline (cuttee): {"paths":[[[0.0,0.6],[0.4,0.2],[0.5,0.5]]]}
- Dominant language
- Java
- Stars
- 710
- Forks
- 268
- Avg merge
- 7d 23h
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Esri/geometry-api-java
-
bug fixed_to_verify
Esri/geometry-api-java#328 · 3 comments · 1 assignee ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
Esri/geometry-api-java#324 · 17 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Esri/geometry-api-java#321 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 30/100
Esri/geometry-api-java#320 · 1 comment ·
-
cannot reproduce
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Esri/geometry-api-java#316 · 5 comments ·
All issues in Esri/geometry-api-java
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
elastic/gradle-plugins#157 ·
-
enhancement Tools
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
apache/rocketmq-dashboard#5008 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
DETECT_PARAMETER_NAMES=false silently disables @ConstructorProperties-based Creator detection too Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FasterXML/jackson-databind#6229 ·