Esri/calcite-design-system

Internal element in link is getting attribute values set to "false"

Open

#12,208 opened on May 22, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (88 forks)auto 404
bugestimate - 2good first issueimpact - p2 - want for an upcoming milestonep - low

Repository metrics

Stars
 (367 stars)
PR merge metrics
 (PR metrics pending)

Description

monday.com sync: #18048672280

Check existing issues

Actual Behavior

When no href, rel, target are defined, their values are being set to "false" when they should not be

Expected Behavior

  • Values should be set to null instead of false in these scenarios
  • Ensure the button and input components are in alignment with the solution to link
    • If, however, the above cannot be mitigated, is this a Lumina bug we need to explore/follow-up on?

Reproduction Sample

https://codepen.io/driskull/pen/JoogMPM?editors=100

Reproduction Steps

  1. open codepen
  2. Inspect link internals
  3. Notice the span is being set a ref, rel, target when it shouldn't be

Reproduction Version

3.2.0

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

Contributor guide

Research direction
Inspect the link component's code to see how attributes href, rel, target are set. Ensure they are set to null instead of 'false' when undefined. Check if the same pattern exists in button and input components.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65