Thread leak - "Java Sound Manager"

Open
#25 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
backend

Research direction

Start with the MidiJingleSequencer code referenced in the issue and reproduce the behavior by monitoring threads while players log in and out on a vanilla server with CommandBook. Done means player logouts no longer leave accumulating "Java Sound Manager" threads.

Written by the indexing model from the issue text.

Description

Accepted Bug Urgent

Hello,

While debugging my own plugin, i added a command to monitor the threads used by bukkit and all the plugins.
I saw something strange in the output of the command, about 200 "java.util.Thread" called "Java Sound Manager".

So i did some tests with a vanilla server, a craftbukkit server without plugins and after i added all the plugins one by one.

Finally it seems that this kind of Thread is created by CommandBook.

Each time a player logged on the server, a Thread "Java Sound Manager" is created, but this thread is never destroy when the player logout. So after a few hours, depending on how many players you have on your server, you have a lot of useless threads still running :/

Like you said in your code comment in MidiJingleSequencer : " Sounds like utter crap" ^^

Tikkub

Dominant language
Java
Stars
151
Forks
104
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from EngineHub/CommandBook

All issues in EngineHub/CommandBook

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.