MCA convergence is using absolute tolerance rather than relative tolerance

Open
#415 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by reading src/muse/mca.py around line 663 and compare the convergence calculation with equation A.33 in the referenced paper. Confirm how the deviation between supply and demand is computed, then verify that the convergence criterion matches the paper's relative-tolerance definition and check the relevant MCA behaviour.

Written by the indexing model from the issue text.

Description

bug

From the paper:

Screenshot 2024-07-17 140136

However, as you can see here the model is actually using at the absolute difference in the deviation between supply and demand (i.e. we're missing the division by Dk in equation A.33).

Dominant language
Python
Stars
29
Forks
12
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from EnergySystemsModellingLab/MUSE_OS

All issues in EnergySystemsModellingLab/MUSE_OS

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.