Use custom `Serialize` implementations for metric types

Open

#1,159 opened on Mar 2, 2026 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 35/100

Issue type: Refactor
Clarity: Mostly clear
Activity status: Stale
Tech stack: rust
Domain: backend

Research direction

Start by tracing MetricTrait serialization and the current value() call sites, then inspect NPVMetric's handling of a zero denominator. Confirm how erased-serde is used and verify that custom Serialize implementations are actually selected and expose the fallback-comparison case to users.

Written by the indexing model from the issue text.

Description

muse xiii

While we are using the erased-serde crate, which should allow us to do this, ~~we don't actually have custom Serialize implementations for MetricTrait types anyway~~ (edit: we do, but we're not using them); we use the value() method instead. We should fix this. In particular, this would be useful for NPVMetric, to make it clear to the user when we are using the fallback comparison because the denominator is zero.

Dominant language: Rust
Stars: 8
Forks: 5
Avg merge: 11h 31m
Merged PRs (30d): 33

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Databento live: MBO subscription never emits `TradeTick` for `T` records (non-delta `else` branch ends in `continue`) Open

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

nautechsystems/nautilus_trader#5095 · Opened Sep 25, 2026
fix(quality): too-many-parameters counts parameter attributes as parameters Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

Goldziher/poly#28 · Opened Sep 25, 2026
`simulate_extend_ttl_op` overflows on large `extend_to` Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

stellar/rs-soroban-env#1739 · Opened Sep 25, 2026
`TryFromBytes` 0.8.58 generates `PartialEq` without `Eq`, triggering Clippy Open

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

google/zerocopy#3721 · Opened Sep 25, 2026
QUIC endpoint may panic when receiving an empty UDP packet Open

bug good first issue package: quic

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

compio-rs/compio#1069 · Opened Sep 25, 2026

More Rust issues