Can this test be uncommented?

Open
#72 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
testing

Research direction

Read src/psbt/finalizer.rs around line 533 and compare the commented test with rust-secp256k1-zkp pull request #55. Done means determining whether that fix addresses the commented test and, if so, uncommenting it and verifying the relevant tests.

Written by the indexing model from the issue text.

Description

https://github.com/ElementsProject/elements-miniscript/blob/b485f430591252cfd767cadc92c050d72f0baac2/src/psbt/finalizer.rs#L533

Is this comment referring to this fixed bug ? https://github.com/BlockstreamResearch/rust-secp256k1-zkp/pull/55

cc @sanket1729

Dominant language
Rust
Stars
15
Forks
17
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ElementsProject/elements-miniscript

All issues in ElementsProject/elements-miniscript

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.