EddyVerbruggen/cordova-plugin-safariviewcontroller

Change close text / done button

Open

#70 opened on Jun 28, 2017

View on GitHub
 (14 comments) (0 reactions) (0 assignees)Java (159 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (282 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi @EddyVerbruggen ,

is it possible to change the "Done" Button text? I know it's not implemented, but prob. possible to implement? Any Ideas? Also, is it possible to "lift it up" on iPad like it does on the iPhone? Is it possible to decide where the "done" button has to be? (on the right side e.g. instead of the left)

I know these are many questions, but I am just asking what my customer was asking :D

Thanks for your support

Contributor guide

Research direction
Locate where the 'Done' button is created in the plugin source code (likely in platform specific files). Explore if there is an existing API for customization. If not, propose adding a configuration option to set the button text and position via plugin preferences.
Tech stack
javascriptjavaobjective c
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
CordovaiOS developmentAndroid development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70