Eclipse-Station/Eclipse-Station-13

Players can be forcibly resleeved into a previous character

Open

#184 opened on Apr 7, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)DM (8 stars) (28 forks)batch import
bughelp wanted

Description

Brief description of the issue

If a player dies as one character then joins as another, it's possible for the player to be forcibly resleeved into the old character.

What you expected to happen

An attempt to resleeve the old character would result in failure because the player had abandoned it.

What actually happened

The player was pulled out of their new character and into the old one. (This has happened to me before, but what prompted this issue was a recent ahelp from someone else.)

Steps to reproduce

  • Die as Character A.
  • Respawn and rejoin the game as Character B.
  • Have someone find Character A and attempt to resleeve them.
  • Watch your screen suddenly go dark while you're in the middle of doing something as Character B, and realize you're Character A again.

Code Revision

  • 2d211ce582323fb9760472bfe2e922b80253e394 (Apr 03 2019)

Anything else you may wish to add:

  • Pretty simple issue. Not much needs to be said.

Contributor guide

Tech stack
None
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
DreamMaker (DM) language knowledgeUnderstanding of SS13 respawn system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue involves the code handling character resleeving after death. Look for files related to 'resleeve' or 'respawn' in the codebase, likely in a 'code/game/gamemodes' or 'code/modules/resleeving' directory. The bug occurs when a player dies as one character, reconnects as another, and then the old body is found and resleeved. The fix should check if the old character's client is no longer active before allowing resleeving.