EasyEngine/easyengine

`EE_PROXY_TYPE` to be replaced by a utiliy function

Open

#1,388 opened on Feb 6, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)PHP (1,984 stars) (429 forks)batch import
good first issuekind/enhancement

Description

Currently, EE_PROXY_TYPE is a constant, which is the container id of the global nginx-proxy container. It is computed every time during the initialization of an command as it is present in the runner.

The command executed for it is time consuming and also required by only a handful of commands, hence it should not be in the runner. Instead it can be replaced by a utility function which computes it's value only when required.

Once the value is found for the first time, it can be stored in a constant, and on next call is_defined function can be used in the function to check if the value is already there, to skip the time consuming computation for the second time.

Contributor guide

Tech stack
None
Domain
clidevops
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic PHP knowledgefamiliarity with EasyEngine codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the `EE PROXY TYPE` constant in the runner (likely in src/ or similar). Create a utility function that computes the container ID only when needed, storing it in a constant after first computation. Use `is defined` to check if already computed. Refer to similar utility functions in the codebase for pattern. No linked PRs or comments. This is a straightforward refactor with clear steps.