EasyEngine/easyengine

Create common FeatureContext class and extend it in other repos

Open

#1,174 opened on Aug 17, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)PHP (1,984 stars) (429 forks)batch import
good first issue

Description

Currently each command has it's own FeatureContext class which is mostly slimilar. We should add mostly used functions in core and rest of the repos should extend that class and override any method if they need.

Contributor guide

Tech stack
php
Domain
testing
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PHPBehat testingObject oriented design
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue proposes creating a common FeatureContext class in the core repository and having other command repos extend it. Review the existing FeatureContext classes in each command's tests directory to identify duplicated methods. Since the issue is from 2018 with no comments or PRs, it would be beneficial to first confirm with maintainers if this refactoring is still desired and if there are any preferred design patterns. Additionally, examine the Behat configuration to understand how contexts are loaded.
Create common FeatureContext class and extend it in other repos · EasyEngine/easyengine#1174 | Good First Issue