Make ownership filter consistent between relink and rimport
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Active
- Tech stack
- python
- Domain
- authorization, cli
Research direction
Compare the ownership filtering in relink.py with the directory walk in rimport, focusing on how the staging owner and calling user are represented. Resolve whether both commands should check ownership or neither should, then verify that publishing and relinking handle another user's file consistently.
Written by the indexing model from the issue text.
Description
As of #31, rimport walks directories to find files to publish with no regard for who owns the file. relink.py, on the other hand, still filters to just the owner. This is necessary, I think, because the rimport makes it so commands are run as the staging owner, and thus we would need special handling to check that ownership by the calling user is checked.
It may be acceptable to go either way on this: Both check ownership or neither does. It feels weird to have this obvious failure case possibly lead to situations where someone publishes someone else's file but then can't relink it, so I lean towards both checking.
To investigate: Is it even possible for one CSEG user to delete another's file in the input data dir? Yes. In fact, this is what rimport does when relinking! It's only a manual call of relink.py that skips files the user doesn't own.
- Dominant language
- Python
- Stars
- 0
- Forks
- 2
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ESMCI/inputdataTools
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
ESMCI/inputdataTools#30 ·
-
bug
ESMCI/inputdataTools#29 · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
ESMCI/inputdataTools#26 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ESMCI/inputdataTools#25 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
ESMCI/inputdataTools#24 ·
All issues in ESMCI/inputdataTools
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
xinnan-tech/xiaozhi-fde-talk#263 ·
-
rules
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
huggingface/Repo2RLEnv#163 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
huggingface/sentence-transformers#4074 ·
-
comp/dashboard invalid P3
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
NousResearch/hermes-agent#121143 ·