ESCOMP/atmospheric_physics

Remove un-needed "il1g" variable from ZM schemes.

Open

#202 opened on Feb 12, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Fortran (37 forks)auto 404
cleanupgood first issue

Repository metrics

Stars
 (12 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently the zm_conv_convtran_run and zm_conv_momtran_run schemes have an "il1g" input variable which has a standard name of index_of_first_column_of_gathered_deep_convection_arrays.

However, in CAM and CAM-SIMA this variable appears to be hardcoded to one. Thus it would likely clean-up the code if this variable was removed from the relevant subroutine arguments and instead just made a local variable (or all of the relevant uses of the variable were simply replaced with 1).

Note that once this issue has been resolved the "il1g" variable can also be removed from the CAM-SIMA registry as well.

Contributor guide

Research direction
Find all occurrences of the 'il1g' variable in the ZM scheme subroutines, replace with the constant 1, and remove it from the subroutine arguments. Also remove it from the CAM SIMA registry.
Tech stack
None
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
FortranGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75