Problem writing out landmask to history file

Open

#82 opened on Jun 10, 2023 5 comments 0 reactions 1 assignee View on GitHub

@ekluzek is already working on this.

Since Jun 10, 2023.

#49 by @ekluzek — merged

Assessment

This issue has not been assessed yet.

Description

enhancement

I noticed this on the cesm2_3 branch as exact restart tests fail. But, it's an issue that we could have noted on the cesm2_1 branch as well. PIO is failing because _FillValue isn't properly set.

This bit of PIO code is failing (pio_darray.c):

    /* Check that if the user passed a fill value, it is correct. If
     * use_fill is false, then find_var_fillvalue will not end up
     * getting a fill value. */
    if (fillvalue && vdesc->use_fill)
        if (memcmp(fillvalue, vdesc->fillvalue, vdesc->pio_type_size))
            return pio_err(ios, file, PIO_EINVAL, __FILE__, __LINE__);

I think this just means that we need to explicitly set missing_value and _FillValue in the definition of history and restart variables. So I think it's a straightforward fix.

Dominant language: Fortran
Stars: 15
Forks: 9
PR merge metrics: No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Problem writing out landmask to history file

Assessment

Description

Contributor guide

First steps

More from ESCOMP/SimpleLand

Get new issues in your inbox