Convert LH to evap (kg) AFTER doing SH correction

Open
#8 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
fortran
Domain
backend

Research direction

Locate the handling of the evap, lhflx, and shflx variables in the Fortran model. Trace the latent-heat conversion and the sensible-heat correction first, then verify that bucket water removal uses the adjusted evap value. Done means evap remains consistent with lhflx after excess latent heat is transferred to shflx.

Written by the indexing model from the issue text.

Description

bug

Right now I'm converting latent heat flux to water units before doing the "did you try to evaporate more water than you have" check (which puts excess latent heat flux into sensible heat flux). It should happen after, otherwise the evap variable (in water units) won't match the lhflx variable (in energy units) if some of lhflx gets transferred to shflx. Quick fix, but if I try to do it right now when I'm tired I'll break something. I then use evap to subtract water from the bucket, which wouldn't have the adjustment for sensible heat flux included - maybe this is causing some of the soil moisture followed by nan problems. Maybe not. Regardless, it seems wrong, so should be fixed!

Dominant language
Fortran
Stars
15
Forks
9
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ESCOMP/SimpleLand

All issues in ESCOMP/SimpleLand

Similar issues

More Backend & API Design issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.