Convert LH to evap (kg) AFTER doing SH correction
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- fortran
- Domain
- backend
Research direction
Locate the handling of the evap, lhflx, and shflx variables in the Fortran model. Trace the latent-heat conversion and the sensible-heat correction first, then verify that bucket water removal uses the adjusted evap value. Done means evap remains consistent with lhflx after excess latent heat is transferred to shflx.
Written by the indexing model from the issue text.
Description
Right now I'm converting latent heat flux to water units before doing the "did you try to evaporate more water than you have" check (which puts excess latent heat flux into sensible heat flux). It should happen after, otherwise the evap variable (in water units) won't match the lhflx variable (in energy units) if some of lhflx gets transferred to shflx. Quick fix, but if I try to do it right now when I'm tired I'll break something. I then use evap to subtract water from the bucket, which wouldn't have the adjustment for sensible heat flux included - maybe this is causing some of the soil moisture followed by nan problems. Maybe not. Regardless, it seems wrong, so should be fixed!
- Dominant language
- Fortran
- Stars
- 15
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ESCOMP/SimpleLand
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ESCOMP/SimpleLand#95 · 1 comment ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 42/100
ESCOMP/SimpleLand#94 ·
-
enhancement
ESCOMP/SimpleLand#93 · 2 comments · 1 assignee ·
-
enhancement
ESCOMP/SimpleLand#92 · 1 assignee ·
-
CESM3
Difficulty 4/5 3-5 days Newbie friendliness 25/100
ESCOMP/SimpleLand#91 · 2 comments · 1 reaction ·
All issues in ESCOMP/SimpleLand
Similar issues
-
bug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100