Repository metrics
- Stars
- (11,288 stars)
- PR merge metrics
- (No merged PRs in 30d)
Description
As part of the trace_api_plugin development, we spec'd, implemented and then dropped the concept of adding suffixing to time-values to make configuration easier.
The reason we dropped it was that, local to a single plugin, this concept was very inconsistent with the rest of the configurations.
This issue represents a suggestion that we adopt this convention and provide it throughout the whole of the configurations dealing with time durations in a non-destructive way.
In order for it to be non-destructive, the default would most likely need to be milliseconds or microseconds depending on the existing configuration's suffix (-us or -ms) .
Here is an implementation with seconds as the default (reverted in later commits): https://github.com/EOSIO/eos/blob/4dd8a06aa423fe2b35de67648bba54c94699ac40/plugins/trace_api_plugin/include/eosio/trace_api_plugin/configuration_utils.hpp#L12-L52
Here is the applicable unit test for it: https://github.com/EOSIO/eos/blob/4dd8a06aa423fe2b35de67648bba54c94699ac40/plugins/trace_api_plugin/test/test_configuration_utils.cpp#L37-L67