DynamoRIO/drmemory

Add size= and offset= qualifiers to leak and possible leak suppressions

Open

#759 opened on Nov 28, 2014

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (289 forks)auto 404
Component-LeakCheckComponent-SuppressionMigratedPriority-MediumType-Featurehelp wanted

Repository metrics

Stars
 (2,727 stars)
PR merge metrics
 (PR metrics pending)

Description

From rnk@google.com on January 19, 2012 16:01:18

This is to support issue #741 . For leak suppressions where we don't have good symbols, as in issue #18 , it can help make the suppression more precise without resorting to something brittle like mod+offs.

The size= qualifier is fairly obvious in its simplest form. We could support a syntax for alternate sizes, such as size=18|24|32, and perhaps ranges (size=32<=x<=48)?.

The offset qualifier is useful for possible leaks where we have something like an SLIST_ENTRY embedded in a struct, as occurred in issue #18 ole32!EventEntry::CreatePoolEntry.

Original issue: http://code.google.com/p/drmemory/issues/detail?id=759

Contributor guide

Research direction
Examine the existing suppression parsing logic in DrMemory's source code (likely in drmemory/suppress.c or similar). Understand how current qualifiers like 'fun=' are parsed and matched. Then design and implement parsing for 'size=' and 'offset=' qualifiers, supporting optional ranges and alternate sizes. Add tests to verify the new functionality.
Tech stack
c
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40