DynamoRIO/drmemory

add ioctl tests

Open

#379 opened on Nov 28, 2014

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C (289 forks)auto 404
Component-TestsMigratedOpSys-WindowsPriority-LowType-Featurehelp wanted

Repository metrics

Stars
 (2,727 stars)
PR merge metrics
 (PR metrics pending)

Description

From bruen...@google.com on May 04, 2011 15:00:27

currently ioctl handling is based on what's seen in net_unittests so that will server for now as testing (although some of the winsock calls are coming from injected libs from other software on the system and isn't from net_unittests itself :)). long-term should add or perhaps can find basic tests of all winsock functions: at least as no-error tests, ideally adding drmem-specific tests that pass uninit data to syscalls deliberately to test false negatives. that's a lot of work though so there are tradeoffs here to manage.

Original issue: http://code.google.com/p/drmemory/issues/detail?id=379

Contributor guide

Research direction
Examine existing net unittests for ioctl handling patterns and identify minimal test cases for winsock functions. Consider using drmem specific tests with uninitialized data.
Tech stack
c
Domain
testing qa
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30