DynamoRIO/drmemory

XP bot fails to build due to app_suite recent-Windows features

Open

#1,796 opened on Oct 20, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C (289 forks)auto 404
Component-BuildComponent-BuildBotComponent-TestsOpSys-WinXPgood first issuehelp wanted

Repository metrics

Stars
 (2,727 stars)
PR merge metrics
 (PR metrics pending)

Description

http://build.chromium.org/p/client.drmemory/builders/win-xp-drm/builds/5407/steps/Dr.%20Memory%20ctest/logs/stdio

drmemory-dbg-32: **** 7 build errors ****
    156&gt:..\..\..\..\drmemory\tests\app_suite\fs_tests_win.cpp(132): error C3861: 'GetQueuedCompletionStatusEx': identifier not found
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(37): error C3861: 'CreateBoundaryDescriptor': identifier not found
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(66): error C3861: 'CreatePrivateNamespace': identifier not found
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(72): error C3861: 'OpenPrivateNamespace': identifier not found
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(79): error C2065: 'PRIVATE_NAMESPACE_FLAG_DESTROY' : undeclared identifier
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(78): error C3861: 'ClosePrivateNamespace': identifier not found
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(80): error C3861: 'DeleteBoundaryDescriptor': identifier not found
drmemory-rel-32: **** 7 build errors ****
    156&gt:..\..\..\..\drmemory\tests\app_suite\fs_tests_win.cpp(132): error C3861: 'GetQueuedCompletionStatusEx': identifier not found
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(37): error C3861: 'CreateBoundaryDescriptor': identifier not found
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(66): error C3861: 'CreatePrivateNamespace': identifier not found
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(72): error C3861: 'OpenPrivateNamespace': identifier not found
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(79): error C2065: 'PRIVATE_NAMESPACE_FLAG_DESTROY' : undeclared identifier
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(78): error C3861: 'ClosePrivateNamespace': identifier not found
    156&gt:..\..\..\..\drmemory\tests\app_suite\namespace_tests_win.cpp(80): error C3861: 'DeleteBoundaryDescriptor': identifier not found

Contributor guide

Research direction
Investigate the use of Windows API functions like `GetQueuedCompletionStatusEx`, `CreateBoundaryDescriptor`, etc. in the test files. Add preprocessor guards or alternative implementations for Windows XP builds.
Tech stack
ccpp
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CBuild SystemWindows API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40