Dyalog/ullu

Garbage data input for primitives

Open

#65 opened on Apr 18, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)APL (4 forks)auto 404
Size: Menhancementgood first issue

Repository metrics

Stars
 (5 stars)
PR merge metrics
 (PR metrics pending)

Description

Excerpt from @pmikkelsen's message: A good idea is actually to pass something that isn't an array at all, and make sure we get the correct error. For example, 1+# should give an error. I have seen non-array arguments causing errors more than once.

In the interpreter, there are certain macros to check the rank of an array for example, and it is used like xxx->Rank. If some code is passed a namespace, the xxx->Rank will return garbage data, and likely cause a crash.

Contributor guide

Research direction
Examine the primitive functions to add rank checking and return appropriate errors for non array input.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
APLGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40