Dyalog/ullu

[Primitive] Floor: Redo the model for floor

Open

#37 opened on Dec 14, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)APL (4 forks)auto 404
Size: Mbughelp wanted

Repository metrics

Stars
 (5 stars)
PR merge metrics
 (PR metrics pending)

Description

Redo the model function for floor to handle inputs like 1E200.

The current model of floor calculates it by using a very non-intrusive (with the actual primitive being tested) approach by using strings to calculate the result. But it fails to evaluate inputs like 1E200 and fails.

Contributor guide

Research direction
Examine the floor model's string based calculation to understand why it fails for exponential notation like 1E200. Identify where the parsing logic breaks and consider using number conversion or updating the string algorithm to handle scientific notation.
Tech stack
None
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
APL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75