Doichain/dapp

Security: RPC-API-CALL sendrawtransaction needs validation

Open

#116 opened on Oct 29, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (13 forks)auto 404
A prioritybountyenhancementgood first issuehelp wantedsecurity

Repository metrics

Stars
 (6 stars)
PR merge metrics
 (PR metrics pending)

Description

When calling RPC-API sendrawtransaction please validate and limit the data given over the body parameters to prevent dDoS attacks.

This RPC-Call is located in: meteor-api package: https://github.com/Doichain/meteor-api inside file: server/api/rest/imports/send.js around line 639: Api.addRoute(DOICHAIN_BROADCAST_TX, { parameter*: !params.templateDataEncrypted || ... etc. is not yet limited. The size of this parameter (size of data) should be able to be limited in settings

The question here is if restivus (the REST API package of meteor) already has such capabilities or we must do it AFTER we received 1 GB of data. I think this could be already too late here.

Contributor guide

Research direction
Examine the send.js file in server/api/rest/imports/ to understand how the sendrawtransaction endpoint processes request body parameters. Investigate restivus documentation for built in size limits or implement custom validation before processing data to prevent large payloads.
Tech stack
javascriptnodejsrest api
Domain
backendapisecurityblockchain
Issue type
Security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGitREST API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75