Add/Remove Counters fails
@jkyle is already working on this.
Since Dec 9, 2017.
Assessment
This issue has not been assessed yet.
Description
issue:
When you have added a number of of counters, n, and you remove any counter that's not n, adding a counter fails.
reason:
While trying to add a counter, tries to assign the new counter id to players.length + 1 which is equal to n and has already been consumed.
#14
- Dominant language
- JavaScript
- Stars
- 2
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Dirk-tooth/magicJS
-
Add tests Openenhancement help wanted
Dirk-tooth/magicJS#15 · 2 assignees ·
-
bug help wanted
Dirk-tooth/magicJS#13 · 1 comment · 2 assignees ·
-
dice rolling tools Openenhancement help wanted
Dirk-tooth/magicJS#7 · 2 assignees ·
-
enhancement
Dirk-tooth/magicJS#6 · 1 assignee ·
-
bug
Dirk-tooth/magicJS#5 · 1 assignee ·
All issues in Dirk-tooth/magicJS
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·