Add/Remove Counters fails

Open
#16 2 comments 0 reactions 2 assignees View on GitHub

@jkyle is already working on this.

Since Dec 9, 2017.

Assessment

This issue has not been assessed yet.

Description

bug help wanted

issue:
When you have added a number of of counters, n, and you remove any counter that's not n, adding a counter fails.

reason:
While trying to add a counter, tries to assign the new counter id to players.length + 1 which is equal to n and has already been consumed.

#14

Dominant language
JavaScript
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Dirk-tooth/magicJS

All issues in Dirk-tooth/magicJS

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.